Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport Frustum Visual (#1095) #1101

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Backport Frustum Visual (#1095) #1101

merged 3 commits into from
Jan 27, 2025

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jan 17, 2025 •
edited
Loading

🎉 New feature

Related PR: #1102

Summary

Backport of #1095.

Marked as draft: Please review #1102 first to get the ABI compatibility changes in first.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@BA-Utkarsh @iche033
Visualize Frustum (#1095)
8eddd04 
Adds the visualization of Frustum via a new FrustumVisual class

Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Utkarsh <[email protected]>
Co-authored-by: Ian Chen <[email protected]>
@github-actions github-actions bot added 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels Jan 17, 2025
@iche033 iche033 marked this pull request as draft January 17, 2025 02:26
@BA-Utkarsh BA-Utkarsh mentioned this pull request Jan 17, 2025
Closed
ahcorde
ahcorde previously requested changes Jan 20, 2025
View reviewed changes
examples/frustum_visual/GlutWindow.cc Show resolved Hide resolved
examples/frustum_visual/GlutWindow.cc Show resolved Hide resolved
examples/frustum_visual/Main.cc Outdated Show resolved Hide resolved
examples/frustum_visual/Main.cc Show resolved Hide resolved
examples/frustum_visual/Main.cc Show resolved Hide resolved
@iche033 iche033 marked this pull request as ready for review January 21, 2025 20:09
@iche033 iche033 changed the title [DRAFT] Backport Frustum Visual (#1095) Backport Frustum Visual (#1095) Jan 21, 2025
@iche033 iche033 requested a review from ahcorde January 21, 2025 20:09
@iche033
Copy link
Contributor Author

iche033 commented Jan 23, 2025

@ahcorde can I get another quick look from you?

@BA-Utkarsh
Copy link
Contributor

@iche033 @ahcorde Any update?

@iche033 iche033 dismissed ahcorde’s stale review January 27, 2025 18:09

addressed all comments

@iche033 iche033 merged commit 566857c into gz-rendering9 Jan 27, 2025
10 of 11 checks passed
@iche033 iche033 deleted the backport_frustum_visual branch January 27, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero caguero approved these changes

@ahcorde ahcorde Awaiting requested review from ahcorde

Assignees
No one assigned
Labels
🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty
Projects
Core development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iche033 @BA-Utkarsh @caguero @ahcorde